Skip to content

[Jetpack Focus] Reenable Jetpack Notifications Disabling Feature Flag and Release Notes #19761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2022
Merged

[Jetpack Focus] Reenable Jetpack Notifications Disabling Feature Flag and Release Notes #19761

merged 3 commits into from
Dec 9, 2022

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Dec 9, 2022

Revert #19735 to reenable disable notifications feature

Description

Re-enabling already tested disable-notifications functionality #19619

Testing instructions

Confirm that prevent_duplicate_notifs_remote_field":true value exists in https://public-api.wordpress.com/wpcom/v2/mobile/feature-flags

Case 1: Notifications disabled on WordPress app

  1. Install WordPress app and log in
  2. Go to Notification tab on WordPress app and accept iOS notification permission
  3. Install Jetpack app and log in
  4. Go to Notification tab on Jetpack app and accept iOS notification permission
  5. Jetpack app should redirect to WordPress app
  6. Trigger push notification (write a comment on a blog)
  7. Jetpack should receive a notification. WordPress app should not receive a notification.

Case 2 "Allow Notifications" switch should be visible on WordPress

  1. Install WordPress app and log in
  2. Go to Notification tab on WordPress app and accept iOS notification permission
  3. Staying on Notifications tab, click Settings icon on a top right corner
  4. Allow Notifications switch should be visible.

Regression Notes

  1. Potential unintended areas of impact

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 21.4 milestone Dec 9, 2022
@staskus staskus requested a review from guarani December 9, 2022 07:06
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 9, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19761-1356f97 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 9, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19761-1356f97 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes mentioned this pull request Dec 9, 2022
Merged
4 tasks
@twstokes
Copy link
Contributor

twstokes commented Dec 9, 2022

Reviewing this now. 👀

twstokes
twstokes approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @staskus! 🚀

Both tests passed for me.

@staskus
Copy link
Contributor Author

staskus commented Dec 9, 2022

@twstokes thank you!

@staskus staskus merged commit 86f544c into trunk Dec 9, 2022
@staskus staskus deleted the task/reenable-prevent-notifications branch December 9, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twstokes twstokes twstokes approved these changes

@guarani guarani Awaiting requested review from guarani

@salimbraksa salimbraksa Awaiting requested review from salimbraksa

Assignees

No one assigned

Labels

Jetpack Content Migration Flow Notifications

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

4 participants

@staskus @wpmobilebot @twstokes